devtools-protocol icon indicating copy to clipboard operation
devtools-protocol copied to clipboard

Update loaderId description for requestWillBeSent and responseReceived network events

Open 2tunnels opened this issue 11 months ago • 1 comments

Updated the loaderId description in the Network.requestWillBeSent and Network.responseReceived events to mention that they might be empty for preflight requests, not just worker requests. Thought this would make things clearer for anyone digging into network request details.

2tunnels avatar Feb 01 '25 15:02 2tunnels

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 01 '25 15:02 google-cla[bot]

The definition are coming from Chromium/DevTools repo and need to update there. For Chromium Repo - https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md And the file location is https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/devtools_protocol/browser_protocol.pdl

Lightning00Blade avatar Jul 25 '25 20:07 Lightning00Blade