devtools-protocol icon indicating copy to clipboard operation
devtools-protocol copied to clipboard

`Promise` versions of `on(event: ...)` type definitions?

Open kazarmy opened this issue 3 years ago • 0 comments

Shouldn't there be Promise versions of the on(event: ...) type definitions in types/protocol-proxy-api.d.ts? For example, there should also be

loadEventFired(): Promise<Protocol.Page.LoadEventFiredEvent>;

for https://github.com/ChromeDevTools/devtools-protocol/blob/bfcd0a38fec44a7104e1b542005328f2023c4a24/types/protocol-proxy-api.d.ts#L2958

All the other non-on(event: ...) methods return a Promise so this inconsistency is somewhat perplexing.

kazarmy avatar Jun 09 '21 11:06 kazarmy