ChristopherRogers1991

Results 37 comments of ChristopherRogers1991

https://github.com/MycroftAI/mycroft-core/pull/2150 on core will need to go in before this (to get the `State` enum).

@krisgesling, Those are type hints. I have used them in some places in mycroft core, but this may be the first time I've submitted a skill that had them. Assuming...

It looks like the only place in core that I also put type hints is https://github.com/MycroftAI/mycroft-core/blob/dev/mycroft/skills/common_iot_skill.py, which isn't used/won't be used until this skill goes in, which is probably how...

Given it's current level of accuracy, I think it should probably either be fixed or disabled. When I first started using it, I hadn't seen anything else in the marketplace....

I pasted it on #677, but just because I've got it handy, here's what I currently see when I try to generate my README: ![selection_001](https://user-images.githubusercontent.com/8608191/49045884-5650d700-f1a0-11e8-9a60-f269beea63d3.jpg) The biggest notes are that...

I want to be direct, and I have the suspicion that over a textual communication channel, it's going to come off as very negative and perhaps even hostile, so I...

Hey Kathy, Thanks for the update and the details. A couple thoughts: > Pixel perfect preview is hard to maintain; it it sets a high expectation - we want the...

Hey, just a few notes that will hopefully make a compelling counter argument (also on mobile, so hopefully this formats ok): When I worked with the function, it did not...

I don't think targeting the bottom is a good approach - we should be aiming for the best developers. If the primary goal of the library is still to support...

Hmm... I thought I had just wrapped `extract_numbers_en`, or similar, and just grabbed the first out of there (been too long since I had my hands in the code). In...