github-act-runner icon indicating copy to clipboard operation
github-act-runner copied to clipboard

Published 20 hours ago • verified publisher icon ChristopherHX

Upcoming runner-admin / broker / run / results / launch service support

Open ChristopherHX opened this issue 2 years ago • 11 comments

Based on ~~GitHub Changelog~~ https://github.com/actions/runner/issues/886#issuecomment-1669631425, they aim to make the breaking change on ~~July 31, 2023~~ end of August / early September timeframe and start to send the new RunnerJobRequest message.

actions/runner protocol changes

github/actions-runner-admin

  • https://github.com/actions/runner/pull/2487
  • https://github.com/actions/runner/pull/2490
  • https://github.com/actions/runner/pull/2505

broker

  • https://github.com/actions/runner/pull/2500

github/actions-run-service (written in go source)

  • https://github.com/actions/runner/pull/1933
  • https://github.com/actions/runner/pull/2158
  • https://github.com/actions/runner/pull/2412
  • https://github.com/actions/runner/pull/2423
  • https://github.com/actions/runner/pull/2461
  • ~~the new protocol isn't fully implemented yet on the actions/runner, some code only works with the old protocol~~, seems to change shortly

github/actions-results-service (written in go source(1) and source(2))

  • https://github.com/actions/runner/pull/2301
  • https://github.com/actions/runner/pull/2334
  • https://github.com/actions/runner/pull/2422
  • https://github.com/actions/runner/pull/2447
  • https://github.com/actions/runner/pull/2510
  • https://github.com/actions/runner/pull/2516
  • https://github.com/actions/runner/pull/2531

launch service (github/actions-dotnet based)

  • https://github.com/actions/runner/pull/2529

This runner changes

  • [x] https://github.com/ChristopherHX/github-act-runner/pull/71
  • [x] https://github.com/ChristopherHX/github-act-runner/pull/87
  • [x] https://github.com/ChristopherHX/github-act-runner/pull/99
  • [x] Renew job requests
  • [x] Send final step state in job completed message
  • [x] Send step state updates to results service
  • [x] Send step and job logs to the results service
  • [ ] #165

This change could make all current github-act-runner releases unusable and you are forced to update from old releases.

ChristopherHX avatar Feb 06 '23 14:02 ChristopherHX

I wonder how I could test the new protocol, until it is live. Theoretically jobs from RunnerJobRequest can work right now in the main branch, but maybe I made a mistake.

At least with https://github.com/ChristopherHX/github-act-runner/pull/126 I assume it should work.

ChristopherHX avatar May 03 '23 20:05 ChristopherHX

There has been an update to the timeline of the breaking change: https://github.com/actions/runner/issues/886#issuecomment-1669631425

Thank you all for being patient with us. 🙇🏼‍♂️ As bryanmacfarlane mentioned earlier, we are almost there for this feature, since this involves some pretty significant changes on our end, we are being careful in the process, and we are currently addressing a few scale concerns. We'd like to do some load testings as well. The current ETA for beta testing this feature is end of August / early September timeframe. Again thank you very much for using Actions and being patient while we make these changes.

The next weeks are safe from the coming breaking change.

ChristopherHX avatar Aug 08 '23 19:08 ChristopherHX

Another update, self-hosted runners can be affected (if that date is actually correct and they don't postpone it again) starting with 12. September 2023 on github.com src: https://github.blog/changelog/2023-08-29-github-actions-review-network-access-settings-for-the-self-hosted-runners/. At least the changelog entry reads to imply some server change like moving the protocol over to the new backend.

ChristopherHX avatar Aug 29 '23 18:08 ChristopherHX

:warning: Release <= v0.6.4 has a bug, which prevents uploading logs via results service.

Partial testing now possible, results receiver endpoint now defined.

ChristopherHX avatar Sep 02 '23 16:09 ChristopherHX

~~Warning github-act-runner may stopped working!, please investigate~~ (resolved)

github-actions[bot] avatar Oct 19 '23 23:10 github-actions[bot]

FWIW, I just ran our snmalloc workflow that uses github-act-runner and things look fine, so that alert may just be a local thing in the regression test.

nwf-msr avatar Oct 20 '23 17:10 nwf-msr

It was an outage of the deb repository used for installing the runner, until now we are still using the good old protocol. The only thing changed is that the GitHub Actions Services are now powered by .net (core) and Kestrel (a new http header appeared)

ChristopherHX avatar Oct 20 '23 18:10 ChristopherHX

Status Update

They seem to officially target Q1 2024 for this change now...

Long waiting to be hit by announced backend changes

ChristopherHX avatar Dec 30 '23 20:12 ChristopherHX

Alert Regression Public beta of Actions streaming logs with backscroll seem to break live logs.

Logs still appear if the job finished and you refresh the page.

Maybe this runner need to start to also do dual upload of step updates to both old and new backed like the official runner.

ChristopherHX avatar Jan 23 '24 10:01 ChristopherHX

Release v0.6.8 fixes the live log issue, consider updating to resolve the regression using the beta backend

ChristopherHX avatar Jan 23 '24 14:01 ChristopherHX