Shopware-6-Blog-Plugin icon indicating copy to clipboard operation
Shopware-6-Blog-Plugin copied to clipboard

Published 20 hours ago • verified publisher icon ChristopherDosin

ISSUE-110 Fix default thumbnail size and fix used pictures

Open timonf opened this issue 2 years ago • 4 comments

What I did:

  • Fixed default image size (kept aspect ratio, increased image quality, added more sizes).
  • I guess there were 2 sizes intended: 330px and 650px. I kept them and also added 900 and 1280px. Each aspect ratio is 16:9 (330px in width means 185px in height).

Fixes #110

timonf avatar Jun 07 '22 15:06 timonf

@hungmac-sw Please review this PR when you are available. Thank you.

viennt avatar Jul 04 '22 03:07 viennt

Hi @timonf , please update the change log files too, and then we can merge this PR. Thanks.

viennt avatar Jul 27 '22 06:07 viennt

Hi @timonf , please update the change log files too, and then we can merge this PR. Thanks.

@viennt Below 1.5.8 section or as a new 1.5.9 section? I see 1.5.8 is already tagged, so I would go with 1.5.9

timonf avatar Jul 29 '22 09:07 timonf

@viennt Below 1.5.8 section or as a new 1.5.9 section? I see 1.5.8 is already tagged, so I would go with 1.5.9

@timonf Then 1.5.9, please. Thank you.

viennt avatar Jul 29 '22 09:07 viennt

Hi @viennt,

I finally added changelog entries for plugin version 1.5.9 and changed the version in the composer.json file. I also move two entries to 1.5.9 that did not exist at the 1.5.8 tag (https://github.com/ChristopherDosin/Shopware-6-Blog-Plugin/blob/1.5.8/CHANGELOG_en-GB.md).

Ready to merge and tag :)

timonf avatar Oct 28 '22 15:10 timonf