Christopher Davis

Results 83 comments of Christopher Davis

Hi @mattijn, I didn't totally understand the `str` vs `={}` distinction you mentioned. Does that explain which of these functions are working and which don't? Do you see what the...

I'm still a little apprehensive about having something like `alt.X().axis` evaluate to something different from the method `alt.X().axis()`. Overall that just seems kind of confusing to me. What would you...

Thanks @joelostblom! It's interesting reading https://github.com/altair-viz/altair/pull/2517#issuecomment-978455614 again, because that comment seems to almost be the opposite of what I thought was going on in this PR. I had thought that...

Hi @joelostblom, I think I tracked down what the issue is with `impute` and some of the other methods we're trying to define. I think the problem is this line:...

Sounds great to me! I feel like this code runs when the class is instantiated, not when the method is called, so raising a warning doesn't seem like the right...

Maybe we could stick to your original `if`-`elif` for now since that seems like a change that's less likely to inadvertently break anything else, and make a separate PR with...

Hi @mattijn, I made a first attempt at fixing this problem here: https://github.com/vega/vega-lite/commit/0ab291a413c58728212c2a9570afbb6b99185454 The resulting extended Vega-Lite for your first chart above is this: [Open the Chart in the Vega...

Hi @mattijn, I think these changes you mention always(?) happen in the transition to the "extended Vega-Lite spec" (visible at the bottom of the Vega editor). For example, I think...

Thanks @mattijn! No, that spec you linked is not working for me either, but it gives a different error, `Unrecognized signal name: "brush"`, so maybe that is a sign of...

Maybe?! But my inclination is always to give the benefit of the doubt to my past self, not to my current self who has looked at it for 2 minutes...