Christopher Davis
Christopher Davis
@mattijn I haven't worked on the Vega-Lite issues you raised in https://github.com/altair-viz/altair/pull/2671#issuecomment-1244085790. If this code seems to be working for you (and not too complicated), I will start thinking about...
Thanks @mattijn! I see now that I had updated the Vega version in the wrong place; it should be corrected now. I also updated vega-lite to 5.5.0. Does that sound...
@mattijn Here's one concern I have related to the failing tests. If I understand right, the failing layer chart test, for example, asserts that adding a selection parameter to a...
**Edit** As I think about it, maybe the parameter should only be distributed if it doesn't have a `views` property already? Overall these fixes feel a little ad hoc to...
Hi @mattijn, I think the only failing tests at this point are the two related to `test_interactive_layered_crossfilter`. And as far as I understand, I don't think we know how to...
Those six examples you provided https://github.com/vega/vega-lite/issues/6890#issuecomment-1266821631 are super helpful @mattijn. I haven't wrapped my head around the different scenarios yet. Just as a big-picture overview, do you think your option...
Hi @mattijn, thanks for the continued testing! I think I got the RepeatChart issue fixed. I haven't thought yet about your scenarios 3 and 4 that you mentioned in https://github.com/altair-viz/altair/pull/2671#issuecomment-1244085790...
Thanks as always for the feedback @mattijn. I think your four scenarios from https://github.com/altair-viz/altair/pull/2671#issuecomment-1244085790 are currently working. Could you please check and see if you agree? Anything overall that seems...
Thanks @mattijn! These "data missing" error messages usually mean the parameters are in the wrong place, and that seems to be the case here. I'll take a look.
Hi @mattijn, luckily it seems like the same fix that worked for LayerChart also works in this case. Do your examples now seem to be working? Please keep sending any...