nextcloud_sentry icon indicating copy to clipboard operation
nextcloud_sentry copied to clipboard

Remove deprecated private DSN

Open ChristophWurst opened this issue 7 years ago • 3 comments

Feature Request

Only use the "public" DSN.

From https://docs.sentry.io/error-reporting/quickstart/?platform=javascript#configure-the-sdk

As of Sentry 9, we removed the need to provide the secret key. Older versions of SDKs may still require you to provide the DSN including the secret which is now called DSN (Legacy).

:warning: might not work for older, on-premise installations https://github.com/getsentry/sentry-electron/pull/61.

ChristophWurst avatar Dec 05 '18 08:12 ChristophWurst

I'd say we just kill of the public-dsn with v5

rullzer avatar Mar 25 '19 19:03 rullzer

Ah wait we need some migration step indeed. Ok then lets do a DSN service that just grabs the right DSN. And then put a warning up somewhere.

rullzer avatar Mar 25 '19 19:03 rullzer

I would do a simple migration step.

If the public dsn is set, we're done. Otherwise, the private dsn should be set (this was the requirement in the past). We pass that to Raven_Client::parseDsn(), build a new one without the password and set it as public dsn.

Then we don't need any warning. The migration should just work for all installations.

ChristophWurst avatar Mar 26 '19 08:03 ChristophWurst