BAC0 icon indicating copy to clipboard operation
BAC0 copied to clipboard

Add mypy type annotations to BAC0

Open gnmerritt opened this issue 2 years ago • 4 comments

BAC0 doesn't currently have many type annotations in place, I'd like to take a quick first pass at generating and adding them so that it's easier to work with the codebase.

I've previously had good luck with https://github.com/Instagram/MonkeyType and then manually editing its results where necessary.

I'd also like to add mypy to the github test workflows, so we can prevent regressions once the annotations are in place.

This is a larger change so wanted to start a discussion before writing a whole mess of code - what do you think?

gnmerritt avatar Apr 28 '22 19:04 gnmerritt

I'm not against... there will be some challenges but why not...

ChristianTremblay avatar May 05 '22 18:05 ChristianTremblay

Ok cool. Definitely won't be 100% coverage and I won't add any coverage-based checks to the workflows. I'm hoping to get a chance to work on this in the next couple weeks...

gnmerritt avatar May 05 '22 18:05 gnmerritt

This issue had no activity for a long period of time. If this issue is still required, please update the status or else, it will be closed. Please note that an issue can be reopened if required.

github-actions[bot] avatar Jul 05 '22 03:07 github-actions[bot]

Finally got started on this last week! Made some good progress but still need to figure out how best to collect types for the TaskManager threads (since monkey type only runs in the parent process)

gnmerritt avatar Jul 05 '22 03:07 gnmerritt

This issue had no activity for a long period of time. If this issue is still required, please update the status or else, it will be closed. Please note that an issue can be reopened if required.

github-actions[bot] avatar Sep 04 '22 03:09 github-actions[bot]