laravel-favorite
laravel-favorite copied to clipboard
Added supp uuid
Description
up uuid
Motivation and context
no why
https://github.com/ChristianKuri/laravel-favorite/issues/20
How has this been tested?
Types of changes
What types of changes does your code introduce? Put an x
in all the boxes that apply:
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
Go over all the following points, and put an x
in all the boxes that apply.
Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
- [x] I have read the CONTRIBUTING document.
- [x] My pull request addresses exactly one patch/feature.
- [x] I have created a branch for this patch/feature.
- [x] Each individual commit in the pull request is meaningful.
- [ ] I have added tests to cover my changes.
- [ ] If my change requires a change to the documentation, I have updated it accordingly.
If you're unsure about any of these, don't hesitate to ask. We're here to help!
The reason I have not merged this pull request is because it doesn't have a test that shows it does work using uuids, please add some tests, and ill merge it
We need tests to verify that this works or I will not merge it.
I'm waiting for this change, because many external repositories uses uuid instead of ints.