winutil icon indicating copy to clipboard operation
winutil copied to clipboard

Changing Uninstall Edge Tweak

Open Linget0 opened this issue 1 year ago • 0 comments

Pull Request

Title

Uninstalling Edge Tweak

Type of Change

  • [*] Refactoring

Description

Tweak uninstalls Edge through its built-in uninstaller by tricking the system into thinking it's in the EU where it allows users to uninstall Edge. When you run the Remove Microsoft Edge tweak Edge will pop up with its own uninstaller asking if you want to remove click Uninstall and its gone. This keeps WebView2 and is a cleaner way than full removal which can cause problems when reinstalling in the future

Testing

[Detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.] Tested on VM with windows 10/11 on fresh installs

Impact

[Discuss the impact of your changes on the project. This might include effects on performance, new dependencies, or changes in behavior.] Uninstalls Edge which is by default the only browser, installing a different one beforehand is highly recommended

Issue related to PR

[What issue/discussion is related to this PR (if any)]

  • Resolves #2485

Additional Information

This is my 2nd try at a PR my first one had a lot of problems hopefully this one is a lot better and doesn't contain a winutil.ps1 or winutil1.ps1 lol the code isn't great and im pretty new to GitHub but it gets the job done in uninstalling Edge from the system. Also, for the Invoke-WebRequest I used the link to my repo with edgeremoval.ps1 so it works for testing purposes but changing it back to winutils repo edgeremoval.ps1 if approved would be better as the PR would change the edgeremoval.ps1 on the winutil repo.

Link to my cloned repo https://github.com/Linget0/WPFEdgeRemoval/blob/main/edgeremoval.ps1

Checklist

  • [*] My code adheres to the coding and style guidelines of the project.
  • [*] I have performed a self-review of my own code.
  • [*] I have commented my code, particularly in hard-to-understand areas.
  • [*] I have made corresponding changes to the documentation.
  • [*] My changes generate no errors/warnings/merge conflicts.
  • If you run the tweak with edge already uninstalled it will give an error saying setup.exe can't be found as edge as already been uninstalled.

Linget0 avatar Aug 04 '24 01:08 Linget0