Disable the Generate Sponsors Cronjob on Forks
Type of Change
- [x] Bug fix
Description
Disables the Generate Sponsors Cronjob on Forks At the moment, the workflow tries to run periodically on all up-to-date forks but fails because ${{ secrets.PAT }} is not configured. Depending on the Configuration of the User this results in failure E-Mails being sent to the user periodically.
This change was directly taken from the PR #2402 by @wojsmol
Impact
No more Email and Notification Spam for Contributors
Issue related to PR
- Resolves #2468
Additional Information
The original PR also disabled the Compile and Close Issue Action. I don't see why this would be necessary because these actions run without a problem. Therefore I omitted them from this PR
@Marterich Quoting from my issue
.github/workflows/compile.yamlis causing thatmainbranch on fork is at least 1 commit ahead of main branch of this repository when synchronizing fork In addition if someone create PR directly frommainbranch then that PR contains updatedwinutil.ps1and this is not intended change.
This also occurs on any branch created from main and is visible on https://github.com/Marterich/winutil/commit/af4958dd8c2b85d42d04307bcaf717cdf69a81e6
@Marterich Quoting from my issue
.github/workflows/compile.yamlis causing thatmainbranch on fork is at least 1 commit ahead of main branch of this repository when synchronizing fork In addition if someone create PR directly frommainbranch then that PR contains updatedwinutil.ps1and this is not intended change.This also occurs on any branch created from
mainand is visible on Marterich@af4958d
Fair argument. But the problem with downright disabling it would be, that at the moment, you can be certain that if you modify something, the winutil.ps1 in your fork is up-to-date. This would not really be the case anymore.
I thought about how to fix this in the past and I almost always came to the conclusion, that probably the only "real" solution to once and for all get rid of the "winget.ps1 has changed and needs is included in a PR" Problem, would be to remove the file completely from the Git Tracking (and therefor all repos) and only include the compiled File in the Releases and Pre-Releases, but I think a change like this should be carefully examined.