Refactor utility functions
Type of Change
- [x] Refactoring
Description
- Separate utitility functions into user manager functions and monitor control functions so that xorg will not be installed when user account manager is used.
- Disable some shell checks and formatting
- Remove redundant function calls
Testing
- Tested on arch linux without issues.
Checklist
- [x] My code adheres to the coding and style guidelines of the project.
- [x] I have performed a self-review of my own code.
- [x] I have commented my code, particularly in hard-to-understand areas.
- [x] My changes generate no errors/warnings/merge conflicts.
I don't feel like this is necessary. The changes here don't really improve anything.
Currently when user tries to use the user account manager commands it installs xrandr from the utility functions script. This PR separates monitor functions and user manager functions so that xrandr is not installed when trying to use user manager scripts. ( Already mentioned in PR description )
Currently when user tries to use the user account manager commands it installs xrandr from the utility functions script. This PR separates monitor functions and user manager functions so that xrandr is not installed when trying to use user manager scripts. ( Already mentioned in PR description )
Is this even an issue though? I feel like structuring scripts like this would only make the codebase more confusing and new first-time contributions potentially harder.
Is this even an issue though?
Yes it is a wayland user getting xorg, xrandr installed automatically when trying to use the user manager is a problem.
I feel like structuring scripts like this would only make the codebase more confusing and new first-time contributions potentially harder.
How separating functions into their own respective module makes it confusing? Monitor functions will be inside the monitor directory and user functions will be inside user directory. Right now having two confirm actions functions and all the monitor utility related code and user manager related code in same file is more confusing.