linutil icon indicating copy to clipboard operation
linutil copied to clipboard

Added support for installing podman

Open Albert-LGTM opened this issue 1 year ago • 6 comments

Type of Change

  • [x] New feature

Description

I added a new feature to install Podman and Podman Compose in the installation script.

Testing

I tested the script on Fedora using dnf and Ubuntu with apt and pip3. Podman and Podman Compose were installed and worked as expected.

Impact

This change allows users to install Podman and Podman Compose for those who wish to use it instead of docker

Additional Information

podman-compose is only available to the dnf package manger, for other distroes it uses the pip3 package.

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] I have made corresponding changes to the documentation.
  • [x] My changes generate no errors/warnings/merge conflicts.

Albert-LGTM avatar Oct 09 '24 11:10 Albert-LGTM

Please test your changes before submitting a PR. Read the Guidelines.

adamperkowski avatar Oct 09 '24 11:10 adamperkowski

Also, you need to run cargo xtask docgen in the root directory.

adamperkowski avatar Oct 09 '24 11:10 adamperkowski

podman-compose is available as a package in arch/extra (here, here), debian >= 12 (so also ubuntu) with apt (here) and openSUSE >= Leap 15 with zypper. Took me one quick web search. Don't use pip.

adamperkowski avatar Oct 09 '24 12:10 adamperkowski

I have updated the installation method to use the package manager instead of pip. I am sorry for overlooking the package manager option.

I also wanted to clarify that the LLM comment was derived from the docker-setup.sh which my script is based upon.

Albert-LGTM avatar Oct 10 '24 12:10 Albert-LGTM

I have updated the installation method to use the package manager instead of pip. I am sorry for overlooking the package manager option.

No problem.

I also wanted to clarify that the LLM comment was derived from the docker-setup.sh which my script is based upon.

Well, that's unfortunate. I wonder who "wrote" docker setup...... @nnyyxxxx ??

adamperkowski avatar Oct 10 '24 12:10 adamperkowski

click commit on these new suggestions and this Pr should be ready to go! @Albert-LGTM

ghost avatar Oct 10 '24 13:10 ghost