linutil icon indicating copy to clipboard operation
linutil copied to clipboard

fix(ci): `bashisms.yml`. again. will work all the time this time i swear.

Open adamperkowski opened this issue 1 year ago • 1 comments

Type of Change

  • [x] Bug fix
  • [x] Hotfix

Description

Yeah so changed a bit here.

  1. Does not use GitHub Output to store the list now (this was the main issue here), instead creates a file
  2. Still uses GitHub Output for storing a bool
  3. It's now easier to debug beacause the list is being echoed
  4. The file is being removed at the end

And yeah that's about it. Will work now. Still, it'd be much better to just grap the checkbashisms binary but Debian doesn't seem to care.

Testing

I waste too much time testing workflows. GitHub should make that easier somehow. (yes, it's tested)

Additional Information

Any additional information that reviewers should be aware of? Nope, not here.

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [x] My changes generate no errors/warnings/merge conflicts.

Oopsie forgot about resolves #711

adamperkowski avatar Oct 01 '24 02:10 adamperkowski

Oh and here you go: https://github.com/adamperkowski/linutil/pull/11/checks You can click the little commit hash on the left to see the ~pro~regress.

adamperkowski avatar Oct 01 '24 02:10 adamperkowski