linutil icon indicating copy to clipboard operation
linutil copied to clipboard

added waterfox browser

Open hexisXz opened this issue 1 year ago • 8 comments

Type of Change

  • [x] New feature
  • [ ] Bug fix
  • [ ] Documentation update
  • [ ] Refactoring
  • [ ] Hotfix
  • [ ] Security patch
  • [ ] UI/UX improvement

Description

Testing

Issues / other PRs related

  • Resolves #

Additional Information

Checklist

  • [ I am 95% sure it does] My code adheres to the coding and style guidelines of the project.
  • [ YES] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ YES] My changes generate no errors/warnings/merge conflicts.

If you see that i edited the Cargo file in core thats because i was trying something out but i reverted it back the the cristitus url so dont worry about that.

also i did test this and it works. (for me at least)

hexisXz avatar Sep 30 '24 03:09 hexisXz

            pacman)
                "$AUR_HELPER" -S --needed --noconfirm waterfox-bin
                ;;
            *)
                . ./setup-flatpak.sh
                flatpak install -y flathub net.waterfox.waterfox
                ;;

its supposed to be like this

ghost avatar Sep 30 '24 04:09 ghost

looks good atm, if they make any changes my opinion will of course change.

okay

hexisXz avatar Sep 30 '24 04:09 hexisXz

@hexisXz resolve all of these reviews please

ghost avatar Sep 30 '24 04:09 ghost

@hexisXz resolve all of these reviews please

like resole the conversations

hexisXz avatar Sep 30 '24 04:09 hexisXz

@hexisXz resolve all of these reviews please

alr i think i did it

hexisXz avatar Sep 30 '24 04:09 hexisXz

@hexisXz keep this PR focused on 1 thing, move the lapce ide section to a different PR

ghost avatar Oct 01 '24 22:10 ghost

@hexisXz keep this PR focused on 1 thing, move the lapce ide section to a different PR

lol you are fast. I tried to delete that before anyone could see it but i think i removed it. this is my first time doing a PR so i actually dont know what i am doing.

hexisXz avatar Oct 01 '24 23:10 hexisXz

@hexisXz Please run cargo xtask docgen and push the changes. Thanks.

adamperkowski avatar Oct 09 '24 11:10 adamperkowski