linutil icon indicating copy to clipboard operation
linutil copied to clipboard
verified publisher icon ChrisTitusTech

Adding Fedora ISO download and fixing a bug in the confirmation prompt.

Open lennartpj opened this issue 1 year ago • 6 comments

Type of Change

  • [x] New feature
  • [x] Bug fix

Description

This pull request adds functionality to download the latest Fedora 40 Workstation ISO in the "create-bootable-usb.sh". It also fixes a bug in the confirmation prompt, allowing users to proceed by entering 'y', 'yes', and case-insensitive variants.

Testing

I have tested the changes by executing cargo run and going through the steps. After the Script executed I was able to boot from the USB stick into the Fedora Setup.

The confirmation prompt now accepts 'y', 'yes', and case-insensitive variants.

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [x] I have made corresponding changes to the documentation.
  • [x] My changes generate no errors/warnings/merge conflicts.

lennartpj avatar Sep 29 '24 16:09 lennartpj

The confirmation prompt accepts 'y', 'yes', and case-insensitive variants. The output is displayed as expected, and the script functions as intended.

Please rewrite the code and this PRs description without using AI/LLMs.

adamperkowski avatar Sep 29 '24 21:09 adamperkowski

Add this to docs/userguide.md

adamperkowski avatar Sep 29 '24 21:09 adamperkowski

Hardcoding releases induces a major maintenance burden. Please use APIs available to you: https://www.fedoraproject.org/releases.json

lj3954 avatar Sep 30 '24 00:09 lj3954

Hardcoding releases induces a major maintenance burden. Please use APIs available to you: https://www.fedoraproject.org/releases.json

Thank you for the advice! I have changed my part accordingly

lennartpj avatar Sep 30 '24 12:09 lennartpj

@lennartpj Please click resolve conversation for all resolved threads here.

adamperkowski avatar Sep 30 '24 13:09 adamperkowski

@adamperkowski
Thank you very much! I still have a lot to learn :)

lennartpj avatar Sep 30 '24 14:09 lennartpj

@adamperkowski I have change the version from 40 to 41. I have also tested the change and made a fresh install of fedora 41 using this method.

lennartpj avatar Oct 30 '24 12:10 lennartpj

https://github.com/ChrisTitusTech/linutil/pull/828 was merged this can be closed

jeevithakannan2 avatar Oct 31 '24 18:10 jeevithakannan2