linutil icon indicating copy to clipboard operation
linutil copied to clipboard

Fix wifi-manager

Open nnyyxxxx opened this issue 5 months ago • 0 comments

Type of Change

  • [x] Bug fix

Description

Simple bug-fix, before the wifi-manager was not requesting credentials; now it does, and now you can successfully connect to any internet connection, I've also fixed the issues with duplicate entries & empty entries when selecting a wifi to connect to.

In this fix I used a temp-file like in the other rewritten util scripts to store the contents of the grabbed wifi-names locally and then remove that file after use; this is a posix compliant approach to bash arrays and unfortunately I do not know any alternatives to storing temp-files, this can be refactored further in the future.

I've also removed the remaining read -s bashisms in this script that weren't removed prior.

Replaced / removed some redundant code as well.

After fixing: image Invalid choice: image Before entry fix: image image image Before wifi connecting fix: image Entering any number here and then pressing enter would just reload the menu and NOT connect you to a wifi-connection

Testing

tested and worked, verified to see if it connected me to the correct wifi, and it did.

Issue related to PR

  • Resolves #455

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [x] My changes generate no errors/warnings/merge conflicts.

nnyyxxxx avatar Sep 18 '24 06:09 nnyyxxxx