linutil icon indicating copy to clipboard operation
linutil copied to clipboard

[CI Workflow] Fix pr-label

Open MyDrift-user opened this issue 1 year ago • 3 comments

Type of Change

  • [x] Bug fix

Description

  • PR's that have text formatted as code crash the workflow due to it not being read as a plain text, therefore will think that is an actual command to run.
  • switch from pull_request to pull_request_target bc of limited GITHUB_TOKEN permission.
  • other little enhancement

Testing

  • tested again on own repo

Issue related to PR

  • Resolves issues of workflows for pr labels

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] I have made corresponding changes to the documentation.
  • [x] My changes generate no errors/warnings/merge conflicts.

MyDrift-user avatar Sep 17 '24 10:09 MyDrift-user

It does later on, that is just a declaration so it can easily be edited later.

Here the part:

if echo "$body" | grep -Eq "\- \[x\] ($pattern)"; then
              labels_to_add+=("$label")

you can see here where I tested it: https://github.com/MyDrift-user/mwm/pull/1

MyDrift-user avatar Sep 18 '24 12:09 MyDrift-user

It does later on

I was looking at a wrong file. That's why i deleted my comment.

adamperkowski avatar Sep 18 '24 12:09 adamperkowski

@MyDrift-user Check Discord.

adamperkowski avatar Sep 18 '24 12:09 adamperkowski