linutil icon indicating copy to clipboard operation
linutil copied to clipboard

SDDM theme with Autologin

Open mashrukk opened this issue 1 year ago • 14 comments

Pull Request

SDDM Astronaut theme with Autologin

This script installs sddm-astronaut-theme from last stream and provides an option to enable autologin with sddm. Users can choose which desktop session they want to autologin on startup. After selecting desktop session, it will do a sddm restart and autologin to that desktop.

Testing

If you want to test it first, do the following.

git clone --branch sddm https://github.com/mashrukk/linutil
cd linutil && cargo run

Type of Change

  • [x] New feature
  • [ ] Bug fix
  • [ ] Documentation Update
  • [ ] Refactoring
  • [ ] Hotfix
  • [ ] Security patch
  • [ ] UI/UX improvement

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] My changes generate no errors/warnings/merge conflicts.

mashrukk avatar Sep 14 '24 16:09 mashrukk

And please don't open any more PRs for the same thing

adamperkowski avatar Sep 14 '24 16:09 adamperkowski

@mashrukk Don't make any more changes to this. It's perfect how it is now.

ghost avatar Sep 14 '24 17:09 ghost

@mashrukk These are the last 2 changes we request of you, thank you for your contribution otherwise.

ghost avatar Sep 14 '24 17:09 ghost

@mashrukk If you'd give me write permissions on your branch, I could squash those commits into one. In your settings

adamperkowski avatar Sep 14 '24 17:09 adamperkowski

@adamperkowski check invite

ghost avatar Sep 14 '24 18:09 ghost

@mashrukk got it

adamperkowski avatar Sep 14 '24 19:09 adamperkowski

@adamperkowski To check dependencies required visit sddm-astronaut-theme

ghost avatar Sep 15 '24 06:09 ghost

Duplicate of #228 partially

guruswarupa avatar Sep 15 '24 07:09 guruswarupa

Duplicate of #228 partially

@guruswarupa I appreciate your work. Instead of making a separate autologin script. It's better to have SDDM with auto login functionality.

ghost avatar Sep 15 '24 07:09 ghost

Duplicate of #228 partially

@guruswarupa I appreciate your work. But Instead of making a separate autologin script. It's better to have SDDM with auto login functionality.

my script auto-login is for multiple display managers. this pr should just work on setting up the theme and not adding features such as autologin which is part of util features, wherein user can choose to keep autologin on or not. what if he doesn't need autologin but wants to have the theme setup? hope you get my point.

guruswarupa avatar Sep 15 '24 07:09 guruswarupa

Duplicate of #228 partially

@guruswarupa I appreciate your work. But Instead of making a separate autologin script. It's better to have SDDM with auto login functionality.

my script auto-login is for multiple display managers. this pr should just work on setting up the theme and not adding features such as autologin which is part of util features, wherein user can choose to keep autologin on or not. what if he doesn't need autologin but wants to have the theme setup? hope you get my point.

whats your take on it? @adamperkowski @nnyyxxxx

guruswarupa avatar Sep 15 '24 07:09 guruswarupa

Duplicate of #228 partially

@guruswarupa I appreciate your work. But Instead of making a separate autologin script. It's better to have SDDM with auto login functionality.

my script auto-login is for multiple display managers. this pr should just work on setting up the theme and not adding features such as autologin which is part of util features, wherein user can choose to keep autologin on or not. what if he doesn't need autologin but wants to have the theme setup? hope you get my point.

@guruswarupa Check the script. It doesn't just set up a theme. It installs SDDM with the theme and asks the user if they want to auto-login, which is optional.

ghost avatar Sep 15 '24 07:09 ghost

@mashrukk yeah fine, also restarting sddm without asking user is unexpected behavior for script to do.

guruswarupa avatar Sep 15 '24 08:09 guruswarupa

@guruswarupa That's a good point. But, If it's executed from TTY and we don't restart. The user will have to type the command enable --now Right? In that case we can just enable it. I need your inputs @adamperkowski @nnyyxxxx

if its added to the sddm.conf, automatically when user restarts the theme should be loaded. in the sddm install add sudo systemctl enable sddm.service

guruswarupa avatar Sep 15 '24 08:09 guruswarupa