linutil
linutil copied to clipboard
Move mybash and CTT nvim to Linutil with minor refactoring
Read everything in this PR before deciding
Check out #404 before merging
Type of Change
- [x] New feature
- [x] Refactoring
Description
~~There is 1 issue with how the cloned dir is being handled; if the folder already exists then it won't work correctly, this can be solved by adding a check to see if that path already exists and to delete it if it does. I did not know if you wanted that functionality or not so I left it out.~~ Solved with 55c6db1
This PR includes refactoring of the setup scripts in the original repositories to follow Posix compliant standards, I rechecked both files using the checkbashisms package to make sure.
More error handling could be added to the nvim-setup script; I have decided to refrain from doing that for now, If you do want more error handling I can make a PR tomorrow.
-
About the package list: I grabbed them out of the original scripts, I am not sure if they are correct; though I am assuming they are since they are from the original scripts.
-
The neovim setup script was rewritten, and the mybash setup script was only partially rewritten. If you see something out of the ordinary in mybash then it for sure was not me.
-
Review the original scripts below and compare them to the rewritten scripts before deciding on what to do with this PR.
-
ref - https://github.com/ChrisTitusTech/mybash/blob/main/setup.sh
-
ref - https://github.com/ChrisTitusTech/neovim/blob/main/setup.sh
Testing
I have tested both scripts in the TUI and out of the TUI, in dash, bash, and they both work perfectly.
~~The only issue I had is listed above.~~ Solved with 55c6db1
Impact
Moves both of the setup scripts over to Linutil so more contributions can be made to these 2 scripts.
Issue related to PR
- Resolves #295
- Resolves #286
- Resolves #268
- Resolves #265
- Resolves #70
- Resolves #251
- Resolves #57
- Resolves #400
- Closes #328
Additional Information
Check the description section.
Checklist
- [x] My code adheres to the coding and style guidelines of the project.
- [x] I have performed a self-review of my own code.
- [x] I have commented my code, particularly in hard-to-understand areas.
- [x] My changes generate no errors/warnings/merge conflicts.