ChrisTitusTech
docker-setup interactive script
Pull Request
Title
cleaner docker-setup for arch, debian and rpm based distros
Type of Change
- closes #306
- interactive script to install docker + docker-compose if users use yml files.
- tested on distrobox for each distro
Checklist
- [x] My code adheres to the coding and style guidelines of the project.
- [x] I have performed a self-review of my own code.
- [x] I have commented my code, particularly in hard-to-understand areas.
- [x] I have made corresponding changes to the documentation.
- [x] My changes generate no errors/warnings/merge conflicts.
@nnyyxxxx and thanks for helping me understand how to workaround certain basic github problems we face. got to learn a lot :)
@guruswarupa IMO the other docker-setup PR is fine; after the final reviews are solved, it should be ready for merge.
I'd recommend closing this for now.
@guruswarupa IMO the other docker-setup PR is fine; after the final reviews are solved, it should be ready for merge.
I'd recommend closing this for now.
@nnyyxxxx well yes, his doesn't include docker-compose which most them use when using docker. + its better to make it interactive than just installing it directly. also his code has too many systemctl commands which i believe the script already does that when i ran in debian. there was no need to start or enable the service. its only needed when we install from package managers which i used for arch install
Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.
@ChrisTitusTech @nnyyxxxx i've fixed those conflicts. ready to be merged.