linutil icon indicating copy to clipboard operation
linutil copied to clipboard

fix: Correctly Detect Pictures Directory and Clone Path for Background

Open rdunne2020 opened this issue 1 year ago • 2 comments

Pull Request

Title

Correctly Detect Pictures Directory and Clone Path for Background

Type of Change

  • [ ] New feature
  • [x] Bug fix
  • [ ] Documentation Update
  • [x] Refactoring
  • [ ] Hotfix
  • [ ] Security patch
  • [ ] UI/UX improvement

Description

The configure_background function couldn't correctly detect existing Pictures directory and installed the nord-background repo to the top level of the Pictures directory

https://github.com/ChrisTitusTech/linutil/issues/303

Testing

Tested both having no Pictures directory and an existing Pictures directory, then ran the DWM-Titus script from the TUI. Both times the images from the nord-background repository wound up in ~/Pictures/background

Impact

N/A

Issue related to PR

  • Resolves #303

Additional Information

This will still fail if you already have a ~/Pictures/nord-background folder that's not empty but that seemed a bit extra to go clobbering that if it existed.

Checklist

  • [ ] My code adheres to the coding and style guidelines of the project.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no errors/warnings/merge conflicts.

rdunne2020 avatar Sep 07 '24 16:09 rdunne2020

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

ChrisTitusTech avatar Sep 12 '24 18:09 ChrisTitusTech

Rebased on top of the new change

rdunne2020 avatar Sep 12 '24 23:09 rdunne2020