linutil icon indicating copy to clipboard operation
linutil copied to clipboard

Remove every bashism

Open nnyyxxxx opened this issue 1 year ago • 6 comments

Type of Change

  • [x] New feature
  • [x] Bug fix
  • [x] Refactoring
  • [x] Hotfix

Description

I replaced every bashism with posix alternatives, I removed the custom color codes that were in almost every file (utilities), I refactored a lot of stuff (utilities), and I made it rely on the common script color codes instead of the custom ones (utilities).

Testing

Tested on bash, zsh, and dash.

Rechecked every file using checkbashisms package

Impact

Greatly impacts the changed sections.

Issue related to PR

  • Resolves #246
  • Resolves #147
  • Resolves #312
  • Resolves #232
  • Resolves #383
  • Resolves #350
  • Closes #278

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [x] My changes generate no errors/warnings/merge conflicts.

nnyyxxxx avatar Sep 06 '24 06:09 nnyyxxxx

https://mywiki.wooledge.org/Bashism

Here is the site I used to squeeze out these bashisms. Might be helpful to Chris in future development.

ghost avatar Sep 06 '24 10:09 ghost

Just squeezed out the last bashisms out of dwm-titus. Ready for review / merge.

ghost avatar Sep 07 '24 23:09 ghost

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

ChrisTitusTech avatar Sep 12 '24 18:09 ChrisTitusTech

Finished.

ghost avatar Sep 12 '24 20:09 ghost

@nnyyxxxx Please include this issue also https://github.com/ChrisTitusTech/linutil/issues/383

jeevithakannan2 avatar Sep 15 '24 05:09 jeevithakannan2

@nnyyxxxx Please include this issue also #383

Thanks.

ghost avatar Sep 15 '24 06:09 ghost

Thanks so much looks awesome @nnyyxxxx

ChrisTitusTech avatar Sep 15 '24 23:09 ChrisTitusTech