ChrisTitusTech
brightness control(xorg) , Auto login DM, Bootable pendrive maker script, auto power profiling using auto-cpufreq, timeshift backup, samba-ssh server setup
Pull Request
Changes Made
- brightness control added into Monitor control util
- auto-login feature for display managers added. Fixes #182
- added {Create Bootable Pendrive} (using dd command by selecting iso) into utils
- the pendrive maker downloads iso from https://archive.archlinux.org/iso/ for arch and official debian website through curl
- sorted the older iso to not show up too old iso's which have different naming convention for the iso file. starts from (2017.04.01)
- auto power profiling using auto-cpufreq for desktops and laptops (Feature Request from youtube comments).
- Timeshift backup util added.
- samba-ssh server setup script (Feature Request from youtube comments).
All of these scripts need to be thoroughly tested in bash & dash. @guruswarupa
@ChrisTitusTech I recommend not merging this, WAY too many issues that need to be addressed.
@guruswarupa Too many bashisms in this PR.
well yes, i'm just waiting for your pr to get approved. later we can make it posix compliant. as of now, i've made a working code for atleast all bash systems. converting it to posix can be done later too. I'll try fixing all those issues right now. but converting it to posix compliant, i've little to no knowledge as of now. i'll try replicating what you did in the pr. thanks
@guruswarupa Too many bashisms in this PR.
well yes, i'm just waiting for your pr to get approved. later we can make it posix compliant. as of now, i've made a working code for atleast all bash systems. converting it to posix can be done later too. I'll try fixing all those issues right now. but converting it to posix compliant, i've little to no knowledge as of now. i'll try replicating what you did in the pr. thanks
I'm not sure Chris will accept this without full posix-compliance, everything here needs to be re-written. Take a look at my reviews, they will help you get started.
@guruswarupa Too many bashisms in this PR.
well yes, i'm just waiting for your pr to get approved. later we can make it posix compliant. as of now, i've made a working code for atleast all bash systems. converting it to posix can be done later too. I'll try fixing all those issues right now. but converting it to posix compliant, i've little to no knowledge as of now. i'll try replicating what you did in the pr. thanks
I'm not sure Chris will accept this without full posix-compliance, everything here needs to be re-written. Take a look at my reviews, they will help you get started.
if i try making it to posix compliant and move the stuff to common-scripts, ill have to rewrite changes you've made in this pr https://github.com/ChrisTitusTech/linutil/pull/282 as its still not pushed to the main. is that fine?
@guruswarupa Too many bashisms in this PR.
well yes, i'm just waiting for your pr to get approved. later we can make it posix compliant. as of now, i've made a working code for atleast all bash systems. converting it to posix can be done later too. I'll try fixing all those issues right now. but converting it to posix compliant, i've little to no knowledge as of now. i'll try replicating what you did in the pr. thanks
I'm not sure Chris will accept this without full posix-compliance, everything here needs to be re-written. Take a look at my reviews, they will help you get started.
if i try making it to posix compliant and move the stuff to common-scripts, ill have to rewrite changes you've made in this pr #282 as its still not pushed to the main. is that fine?
Nothing needs to be moved to the common-script, and no don't rewrite anything that will conflict with #282
@guruswarupa Too many bashisms in this PR.
well yes, i'm just waiting for your pr to get approved. later we can make it posix compliant. as of now, i've made a working code for atleast all bash systems. converting it to posix can be done later too. I'll try fixing all those issues right now. but converting it to posix compliant, i've little to no knowledge as of now. i'll try replicating what you did in the pr. thanks
I'm not sure Chris will accept this without full posix-compliance, everything here needs to be re-written. Take a look at my reviews, they will help you get started.
if i try making it to posix compliant and move the stuff to common-scripts, ill have to rewrite changes you've made in this pr #282 as its still not pushed to the main. is that fine?
Nothing needs to be moved to the common-script, and no don't rewrite anything that will conflict with #282
few color codes are missing in common-scripts which i've used.
@guruswarupa Too many bashisms in this PR.
well yes, i'm just waiting for your pr to get approved. later we can make it posix compliant. as of now, i've made a working code for atleast all bash systems. converting it to posix can be done later too. I'll try fixing all those issues right now. but converting it to posix compliant, i've little to no knowledge as of now. i'll try replicating what you did in the pr. thanks
I'm not sure Chris will accept this without full posix-compliance, everything here needs to be re-written. Take a look at my reviews, they will help you get started.
if i try making it to posix compliant and move the stuff to common-scripts, ill have to rewrite changes you've made in this pr #282 as its still not pushed to the main. is that fine?
Nothing needs to be moved to the common-script, and no don't rewrite anything that will conflict with #282
few color codes are missing in common-scripts which i've used.
You should make a separate PR for that, and change all of the current color codes to the ones in the common-script.
Take a look at the color-codes in this PR #282
@guruswarupa Too many bashisms in this PR.
well yes, i'm just waiting for your pr to get approved. later we can make it posix compliant. as of now, i've made a working code for atleast all bash systems. converting it to posix can be done later too. I'll try fixing all those issues right now. but converting it to posix compliant, i've little to no knowledge as of now. i'll try replicating what you did in the pr. thanks
I'm not sure Chris will accept this without full posix-compliance, everything here needs to be re-written. Take a look at my reviews, they will help you get started.
if i try making it to posix compliant and move the stuff to common-scripts, ill have to rewrite changes you've made in this pr #282 as its still not pushed to the main. is that fine?
Nothing needs to be moved to the common-script, and no don't rewrite anything that will conflict with #282
few color codes are missing in common-scripts which i've used.
You should make a separate PR for that, and change all of the current color codes to the ones in the common-script.
oh.. so only those color codes which are in common-scripts must be used...
@guruswarupa Too many bashisms in this PR.
well yes, i'm just waiting for your pr to get approved. later we can make it posix compliant. as of now, i've made a working code for atleast all bash systems. converting it to posix can be done later too. I'll try fixing all those issues right now. but converting it to posix compliant, i've little to no knowledge as of now. i'll try replicating what you did in the pr. thanks
I'm not sure Chris will accept this without full posix-compliance, everything here needs to be re-written. Take a look at my reviews, they will help you get started.
if i try making it to posix compliant and move the stuff to common-scripts, ill have to rewrite changes you've made in this pr #282 as its still not pushed to the main. is that fine?
Nothing needs to be moved to the common-script, and no don't rewrite anything that will conflict with #282
few color codes are missing in common-scripts which i've used.
You should make a separate PR for that, and change all of the current color codes to the ones in the common-script.
oh.. so only those color codes which are in common-scripts must be used...
Correct. If you want to add more color-codes in the common-script then make a separate PR for that.
Adding color-codes in each script separate from the common-script is quite redundant.
@guruswarupa Too many bashisms in this PR.
well yes, i'm just waiting for your pr to get approved. later we can make it posix compliant. as of now, i've made a working code for atleast all bash systems. converting it to posix can be done later too. I'll try fixing all those issues right now. but converting it to posix compliant, i've little to no knowledge as of now. i'll try replicating what you did in the pr. thanks
I'm not sure Chris will accept this without full posix-compliance, everything here needs to be re-written. Take a look at my reviews, they will help you get started.
if i try making it to posix compliant and move the stuff to common-scripts, ill have to rewrite changes you've made in this pr #282 as its still not pushed to the main. is that fine?
Nothing needs to be moved to the common-script, and no don't rewrite anything that will conflict with #282
few color codes are missing in common-scripts which i've used.
You should make a separate PR for that, and change all of the current color codes to the ones in the common-script.
oh.. so only those color codes which are in common-scripts must be used...
Correct. If you want to add more color-codes in the common-script then make a separate PR for that.
Adding color-codes in each script separate from the common-script is quite redundant.
yes yes i get it. can i get your discord id or something? i need help with squashing. could never squash properly :( , last time i removed old pr and made a new pr with all the changes. this is my first open source contribution :)
@guruswarupa Too many bashisms in this PR.
well yes, i'm just waiting for your pr to get approved. later we can make it posix compliant. as of now, i've made a working code for atleast all bash systems. converting it to posix can be done later too. I'll try fixing all those issues right now. but converting it to posix compliant, i've little to no knowledge as of now. i'll try replicating what you did in the pr. thanks
I'm not sure Chris will accept this without full posix-compliance, everything here needs to be re-written. Take a look at my reviews, they will help you get started.
if i try making it to posix compliant and move the stuff to common-scripts, ill have to rewrite changes you've made in this pr #282 as its still not pushed to the main. is that fine?
Nothing needs to be moved to the common-script, and no don't rewrite anything that will conflict with #282
few color codes are missing in common-scripts which i've used.
You should make a separate PR for that, and change all of the current color codes to the ones in the common-script.
oh.. so only those color codes which are in common-scripts must be used...
Correct. If you want to add more color-codes in the common-script then make a separate PR for that. Adding color-codes in each script separate from the common-script is quite redundant.
yes yes i get it. can i get your discord id or something? i need help with squashing. could never squash properly :( , last time i removed old pr and made a new pr with all the changes. this is my first open source contribution :)
No, I don't use discord, there should be guides on youtube on how to squash commits.
@guruswarupa I recommend marking this as a draft for now.
check out now i've changed the code to follow those posix syntax... lemme know if any changes are required :)
@guruswarupa After making these changes these scripts will need indepth testing.
@nnyyxxxx check the code now :) and yeah vs code throws error when i try doing squash
@guruswarupa You'll have to fix all of the echo commands, some include backslashes and other printf arguments.
@guruswarupa Fix all of these other issues that I reviewed in the mean-time.
i fixed the pendrive escalation.
@guruswarupa Fix all of these other issues that I reviewed in the mean-time.
i fixed the pendrive escalation.
Alright, thanks. Fix up the rest of the issues in the reviews and this PR should be good now. :)
@guruswarupa Fix all of these other issues that I reviewed in the mean-time.
i fixed the pendrive escalation.
Alright, thanks. Fix up the rest of the issues in the reviews and this PR should be good now. :)
i've done all those just cross check once more and were good to go :)
@guruswarupa After you're done, hide all of your comments with reason "resolved" please & thanks.
Also "Bootable pendrive maker bash script" remove bash from the title :).
Alright @guruswarupa now you'll have to squash all of these commits, here is a video.
https://www.youtube.com/watch?v=V5KrD7CmO4o&t
Looks good, but this needs indepth testing.
yeah. as of what i've used, should work on most of the major distros. and yeah i could force push the rebasing using github desktop. vs code throws errors for some reason. thanks :)
Looks good, but this needs indepth testing.
yeah. as of what i've used, should work on most of the major distros. and yeah i could force push the rebasing using github desktop. vs code throws errors for some reason. thanks :)
You should squash everything into 1 commit, also there are some printf's with arguments at the end of the timeshift script might want to change those to "echo".
Looks good, but this needs indepth testing.
yeah. as of what i've used, should work on most of the major distros. and yeah i could force push the rebasing using github desktop. vs code throws errors for some reason. thanks :)
You should squash everything into 1 commit, also there are some printf's with arguments at the end of the timeshift script might want to change those to "echo".
isn't it better to have different commits for different features added?
Looks good, but this needs indepth testing.
yeah. as of what i've used, should work on most of the major distros. and yeah i could force push the rebasing using github desktop. vs code throws errors for some reason. thanks :)
You should squash everything into 1 commit, also there are some printf's with arguments at the end of the timeshift script might want to change those to "echo".
isn't it better to have different commits for different features added?
It's personal preference, but yeah :).
Looks good, but this needs indepth testing.
yeah. as of what i've used, should work on most of the major distros. and yeah i could force push the rebasing using github desktop. vs code throws errors for some reason. thanks :)
You should squash everything into 1 commit, also there are some printf's with arguments at the end of the timeshift script might want to change those to "echo".
isn't it better to have different commits for different features added?
It's personal preference, but yeah :).
and yeah not able to squash cause i had merged main branch of it to my branch :/ throws conflict errors