Chris Marshall

Results 24 comments of Chris Marshall

I'm not 100% sure, but I think it would only require removing the `.lower()` call [here](https://github.com/capitalone/giraffez/blob/master/giraffez/types.py#L90-L92) and then [here](https://github.com/capitalone/giraffez/blob/master/giraffez/src/columns.c#L84) in the C extension, to preserve the case everywhere else. The...

For example 2, I believe it could either error with duplicate column definition (probably the safest, easiest and most consistent with Teradata behavior way of solving it) or it could...

I think for the example 2 that might be pretty easy to implement (pull requests welcome!). With example 1, is the expectation that if there is a pre-existing table that...

I tried to make codecov happy locally, however, I think the difference it calculates in coverage is unavoidable. I think it is mistaken about the error being handled for the...