Chris Maddock

Results 190 comments of Chris Maddock

> If I cancel a build, I would do that for a reason. Either it is hanging, or it is taking too long time (so I want to add a...

> You didn't comment on using an attribute or runsettings setting to change it, that could be an option. I didn't, sorry. I don't like the idea of an attribute...

> The only option I see to get both behaviors from the existing UI is to modify NUnit itself to have a third type of shutdown - first trying a...

Looks good to me! Should the implementation additionally call StopRun(true) at the end of the timeout, so that we attempt to use framework ‘stop’ functionality before VS kills the process?

I think this is a duplicate of https://github.com/nunit/nunit/issues/3063#issuecomment-432788447 - would you agree?

Oh, that's odd. Can you filter with the console? (Using whatever filter the adapter would normally do)

So, if I'm reading the adapter code right, the adapter's dump is built up by combining all the received test events? That's a different from the console TestResult.xml, which is...

Ah ok. So if you run `nunit3-console fqn.dll --explore`, do you get the test listed? (Sorry - there's a limited amount I can test myself on this tablet!)

I'm a little suspicious of AsString - only because it's the only notable difference I can see anywhere! We're also dealing with an invalid XML character being encoded in Xml...

That was my go-to thought to be honest, but from looking at how the adapter does use the engine, I can't think of anything that would be a problem around...