ChrisJL

Results 115 comments of ChrisJL

Yea, solution 2 is nice. We could have some CI that builds the OpenAPI spec, and if it detects what is in the code base is out of date it...

We could have the first part of the CI in a custom pre-commit hook if it's performant enough to not be annoying

> How would I avoid building docs if there are no changes? Would I need to put the spec file in version control for that? Is it even worth to...

Agreed, this seems like a useful enhancement. Were you interested in implementing this yourself, or shall I mark it as up for grabs for other contributors?

As part of this, we should also move GET /size back into the general router, so it requires auth

> Can I implement this one :P Yes :) But I suggest waiting until #106 is merged :P

Maybe two endpoints? An aliveness check which returns as soon as it's serving, and then a readiness check, which is when the caches are ready. This will line up with...

On second thought, and some discussion in #dev-pixels having one health check endpoint should be enough. As long as it returns when the caches are ready, we can use that...

Agree with Scale, we should be careful with this one, as we don't want to be responsible for users who mess up their path.

> you can see codeblocks, but you can't post them (on ios at least), since theres no actual backtick key on the keyboard Switch to numbers, then press and hold...