ChrisLR
ChrisLR
I think the last thing I need to do here is the documentation
This should be good for a first pass :)
@Griatch Sorry for the delay, I encountered a few additional bugs I've changed on my end and still testing. I will remove the part about cmdsets as its easy enough...
@Griatch I have pushed the last fixes I made and put the PR back to draft until I get the tests written
Regarding your comment "Ability to use the same name with different slots" Its the opposite, a component is required to have a unique name. The shared slot lets us have...
I continue to test these changes locally but I think this is ready for a 2nd review :)
As proposed in the discord, a good alternative would be for the method to provide a serializable copy instead. We should probably make a new method for it to avoid...
@Griatch referring to this https://www.evennia.com/docs/latest/Components/Attributes.html#id7 If I understand correctly we are expected to make the changes in-place before it is serialized and then revert them once the serialization is done....
@Griatch yes that could work. It could also be a thin copy, so you don't have to include everything. Maybe even a dict at that point.... Advantages are the dev...
@Griatch right, I'll get this finished asap