generate-sa-idnumbers icon indicating copy to clipboard operation
generate-sa-idnumbers copied to clipboard

"Fake"

Open JarriddW opened this issue 5 years ago • 2 comments

Please add some kind of note to say that the generated ID numbers can be real and already registered. So that future users also know to add some sort of validation on this when working with sensitive information. Like a check to see if the ID Number is a registered ID linked to an RSA Citizen. This also allows people to see another persons sensitive information with their ID number.

I was able to generate my own ID Number and many others within the company and see their data, much of our data is linked to client ID numbers so "fake" ID numbers could cause issues like someone generating an existing users ID number or even using a randomly generated number that actually belongs to a person trying to create an account.

All I ask for is visibly clear information on generator.

JarriddW avatar Nov 08 '19 06:11 JarriddW

Thank you, @JarriddW it is a very good idea to be more explicit about the properties of a generated ID number! What this package actually only does is to generate the control digit, the last digit of an SA ID number; all the other inputs come from the form fields. There is no check if the ID number created this way is held by a real South African or not.

May I suggest that you add information, as you suggest, and send a pull request? If you cannot do it, I will do it eventually, but it may take some time.

Chris927 avatar Nov 08 '19 09:11 Chris927

Good job on the Luhn algorithm. I do agree with both of you especially the fact that POPPI also has some merit here, but....

If you simply state that you will not beheld liable for anything origination from using this service, then you will be fine. I also use a custom built python version for myself that I use as a tester but it's noted that it's only used in testing environments/capacities.

Whoever does anything else with it, is solely responsible for their own actions...

OrrinGradwell avatar Feb 08 '21 13:02 OrrinGradwell