Keypad icon indicating copy to clipboard operation
Keypad copied to clipboard

This library was already on Github

Open softegg opened this issue 7 years ago • 6 comments

This library already lives on Github here: https://github.com/Nullkraft/Keypad

Your fork is missing some of the later revisions I made for handling multiple keys down for real-time stuff by adding state information to the event handler.

softegg avatar Jun 28 '17 19:06 softegg

@softegg I think the version at @Nullkraft should be merged here, because:

  1. This repo has (more) active development
  2. It's linked on the official Arduino page

I'll create a pull request, if @Chris--A approves.

DRSDavidSoft avatar Nov 01 '17 17:11 DRSDavidSoft

@DRSDavidSoft, go for it. This repo is here for the community.

Chris--A avatar Dec 21 '17 11:12 Chris--A

This repo appears to be inactive (last commit was 5 years ago). Maybe it's better to use the Nullkraft repo now, which is ahead of this one anyway.

jamesmyatt avatar Jun 01 '20 22:06 jamesmyatt

This existence of this repo is partly my fault. Early on, when the Arduino teams were fighting internally, they locked the playground for quite some time. I ended up supporting requests for help directly through email so it made it seem as though there was no activity. I admit that I hoped this repo could become the default because I didn't want to fight for control over the URL link used by the Arduino Library Manager.

Chris--A, please let me know if you are against updating the Arduino Library Manager to point to my Nullkraft repo.

Nullkraft avatar Jun 02 '20 00:06 Nullkraft

@Nullkraft Glad that the internal fight is now long over. Did you develop this library? Or rather maintain it?

Will you be willing to merge pull requests in here: https://github.com/Chris--A/Keypad/pulls

And also some commits that @Chris--A initially did here? https://github.com/Chris--A/Keypad/commits/master

DRSDavidSoft avatar Jun 02 '20 01:06 DRSDavidSoft

If I understand correctly you are asking if I would be willing to accept the same pull requests at Nullkraft/Keypad? If so then yes, I never stopped supporting the Keypad library. I was the original author of the library but I only took it as far as the state-machine control. Alexander, a real programmer, later added the keypad event routines among other things. Alexander moved on to working with Wiring which is the upstream language that Arduino IDE uses.

Nullkraft avatar Jun 02 '20 14:06 Nullkraft