sidfactory2 icon indicating copy to clipboard operation
sidfactory2 copied to clipboard

Support custom color schemes

Open Chordian opened this issue 5 years ago • 5 comments

@micheldebree:

In the macOS version, there is no telling where the user puts the drivers, color schemes, and overlays.

Proposed:

  • Look for the .ini file in a fixed location (<user>/.config/sidfactory2/config.ini)
  • Allow overrides to color schemes and overlay folders (or single folder) in the config file

Chordian avatar Sep 12 '20 13:09 Chordian

This is a task migrated from workstreams in Slack.

Chordian avatar Sep 12 '20 13:09 Chordian

The first bullet has been implemented.

micheldebree avatar Oct 20 '20 05:10 micheldebree

Bullet #1 is implemented already; in the config.ini packed inside the app, is an include:

[macos]     // Applies to the macos platform only
#include "~/.config/sidfactory2/user.ini"

micheldebree avatar Jan 23 '21 18:01 micheldebree

The color schemes are a bit harder because:

  • The built-in schemes are packed inside the app
  • The custom schemes in user.ini are relative to the app and cannot be set to something outside the app
  • If you could put additional schemes in user.ini there is no way of telling what number it will get without knowing the contents of config.ini (which is inside the app). User needs this number to set the favorite color scheme.

Solution?

  • interpret filenames like they are now (relative to the application?) and also (new) allow absolute paths. Or interpret the filenames for color schemes as relative to the ini files they are defined in
  • use something else than the index in the list to identify the color scheme so we know how to identify it.
  • combine user.ini and config.ini into one set of options (already works like this)

micheldebree avatar Jan 23 '21 19:01 micheldebree

Changed title of the issue; custom config in user.ini is supported on macOS and linux, the only thing that is not really supported is custom colorschemes on macOS

micheldebree avatar Apr 23 '21 04:04 micheldebree