David Chopin comments

Results 31 comments of


                                            David Chopin

[BUG] Picture-in-picture button has different opacity than other buttons on iOS

I can make a PR on this repo if it will be merged in.

[go_router] Prevent access to route when navigated to via a deep link

> I think there are two steps to fix this issue > > 1. https://github.com/flutter/packages/pull/4392/files > This adds the ability to know whether a GoRouteState is a deeplink (by checking...

[go_router] Prevent access to route when navigated to via a deep link

@chunhtai I was able to get back a `GoRouteState.uri.host` and `GoRouteState.uri.scheme` in our `redirect` with, seemingly, no side-effects by making the following changes: - [`parser.dart`](https://github.com/flutter/packages/blob/d7dee796f3c85f6716191493606e727e744de95a/packages/go_router/lib/src/parser.dart): [`configuration.findMatch(routeInformation.location!, extra: state.extra);`](https://github.com/flutter/packages/blob/d7dee796f3c85f6716191493606e727e744de95a/packages/go_router/lib/src/parser.dart#L90) changes to...

[go_router] Prevent access to route when navigated to via a deep link

@chuntai So, we would need a PR that: 1. Upgrades go_router's min. flutter version to >=3.12.0 (so that `RouteInformation.uri` exists) 2. Implements my aforementioned changes which make use of `RouteInformation.uri`...

[go_router] Prevent access to route when navigated to via a deep link

PR is open @chunhtai: https://github.com/flutter/packages/pull/5742

[go_router] Return a value on pop

> We should not merge this until we figure out this how to support imperative API moving forward > [flutter/flutter#99112](https://github.com/flutter/flutter/issues/99112). Closing for now So we can't get async `push` and...

Made package work on Flutter >=2.10

probably 🤷‍♂️

getting PlatformException(channel-error, Unable to establish connection on channel: "dev.flutter.pigeon.wakelock_plus_platform_interface.WakelockPlusApi.toggle"., null, null) error when running test cases

The only way I could get this to work in a way where I can confirm whether enable/disable message was invoked was to do [this](https://github.com/lichess-org/mobile/pull/2275/files#diff-f3c056fc2241063e75e74070f3c6aad46a1722210e8414c2dc87cb6ded5dce72R795-R838). Basically, you need to be...

Unable to see the play button in-front of individual tests

Same and its unbelievably annoying

Make PlayPauseButton size configurable

@julianfalcionelli Sorry, just now seeing your comment. I don't really maintain this project, just made this and a couple of other PRs. That being said, it does seem that [the...