Choices icon indicating copy to clipboard operation
Choices copied to clipboard

Allow overriding language string for removing an item

Open wilsonge opened this issue 5 years ago • 1 comments

Description

Allows overriding the language string per the TODO in the code. Required for the multilingual setup we're using this for in @joomla

Types of changes

  • [ ] Chore (tooling change or documentation change)
  • [x] Refactor (non-breaking change which maintains existing functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

I'm not 100% on whether this will be a breaking change for people overriding the item template (with the introduction of the new parameter). I think it will be fine but I don't have an implementation of that to hand to test with

Checklist

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.

wilsonge avatar May 09 '20 00:05 wilsonge

This looks great! Can you rebase on the latest version? It would also be nice to have a test for this.

mtriff avatar Dec 19 '21 04:12 mtriff