Choices icon indicating copy to clipboard operation
Choices copied to clipboard

Allow selected options to be hidden when searching

Open samuelhwilliams opened this issue 2 months ago • 3 comments

Description

Adds a new option that allows results to be hidden from the dropdown when searching, if those results have already been selected. This is through a new configuration option searchRenderSelectedChoices, which closely follows the behaviour of renderSelectedChoices. It defaults to be backwards compatible.

Have put this up quite provisionally, happy to take any feedback or change requests (for example if you just want to reuse the existing setting rather than add a new one).

Fixes #1313 Fixes #1353

Screenshots (if appropriate)

Types of changes

  • [ ] Chore (tooling change or documentation change)
  • [ ] Refactor (non-breaking change which maintains existing functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x] My code follows the code style of this project.
  • [x] I have added new tests for the bug I fixed/the new feature I added.
  • [ ] I have modified existing tests for the bug I fixed/the new feature I added.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.

samuelhwilliams avatar Oct 28 '25 23:10 samuelhwilliams

@samuelhwilliams I plan to merge #1357 first, but it looks like your change has some stray changes in the built assets. It may be easier to just revert changes to those files and then force push

Xon avatar Oct 30 '25 01:10 Xon

This does introduce a behavior change with the default of auto instead of false

Xon avatar Oct 30 '25 01:10 Xon

Hi @Xon - I've removed all of the changes in public/assets - sorry, wasn't sure if you'd want those committed directly or not.

samuelhwilliams avatar Oct 30 '25 07:10 samuelhwilliams