Choices icon indicating copy to clipboard operation
Choices copied to clipboard

Published 20 hours ago • verified publisher icon Choices-js

fix/multiple classnames

Open gaetan-hexadog opened this issue 2 years ago • 13 comments

Description

In some cases, we want to be able to pass multiple class names like so 'list first second'. However, this is making an error because classList.add doesn't support space.

This PR attempts to implement allowing multi-class configs for all elements across the board by allowing to pass an array of strings for classNames.

It takes into account feedbacks from PR#907 submitted by @mikebronner

Fix #832 #889

Types of changes

  • [ ] Chore (tooling change or documentation change)
  • [ ] Refactor (non-breaking change which maintains existing functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x] My code follows the code style of this project.
  • [ ] I have added new tests for the bug I fixed/the new feature I added.
  • [x] I have modified existing tests for the bug I fixed/the new feature I added.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.

gaetan-hexadog avatar Nov 20 '22 11:11 gaetan-hexadog

Thanks for this! Can you merge the latest version of master into this branch? After that I will review it.

mtriff avatar Nov 30 '22 02:11 mtriff

Thanks for this! Can you merge the latest version of master into this branch? After that I will review it.

Done ;-)

gaetan-hexadog avatar Nov 30 '22 10:11 gaetan-hexadog

I have a feeling that when @mtriff will get back to this, @gaetan-hexadog will need to merge latest master once again 🤣

ezitisitis avatar Feb 24 '23 23:02 ezitisitis

@mtriff let me know when you'll be able to merge this PR so I can merge the latest version of master before (don't want to do it if you're not going to merge it quickly) ;-)

gaetan-hexadog avatar Mar 19 '23 16:03 gaetan-hexadog

Hey, does anyone know when this PR will be merged?

btmluiz avatar Apr 08 '23 19:04 btmluiz

+1

ammaraslam10 avatar Oct 06 '23 14:10 ammaraslam10

+1

KarelBrijs avatar Oct 16 '23 15:10 KarelBrijs

+1

J2-Tech avatar Dec 15 '23 18:12 J2-Tech

Please come back, we need the multiple class override, thx

otherprod avatar Jan 20 '24 10:01 otherprod

We need this

MeetJF avatar Feb 04 '24 04:02 MeetJF

@gaetan-hexadog Whats with this?

liamseys avatar Apr 05 '24 15:04 liamseys

@gaetan-hexadog Whats with this?

No news from the repo'd owner. I won't work on it for the third time if I don't have the insurance it will be merged quickly. Feel free to use my PR if you want.

gaetan-hexadog avatar Apr 05 '24 15:04 gaetan-hexadog

There should be a protocol for when the owner stops responding for more than a year...

ammaraslam10 avatar Apr 08 '24 20:04 ammaraslam10

Thanks! Implemented as part of #1166

Xon avatar Aug 06 '24 02:08 Xon