PeerTube icon indicating copy to clipboard operation
PeerTube copied to clipboard

Live Replays No Longer Auto-generate Thumbnail

Open vencabot opened this issue 1 year ago • 3 comments

Describe the current behavior

After upgrading from version 6.2.1 to 6.3.1, my stream replays don't get thumbnails unless I set them manually. At first, this triggered the 'transcoding crashes on videos with no thumbnails' bug, but then I upgraded to 6.3.2 and transcoding completes normally, but replays still don't get thumbnails.

Steps to reproduce

  1. Conduct a live stream that is set to publish a replay afterward.
  2. End the stream and wait for the replay to be published.
  3. The replay has no thumbnail assigned, where-as before a frame from the replay would be selected.

Describe the expected behavior

Before I upgraded, VODs would get a frame from the video as a thumbnail by default.

Manually uploaded videos still get a frame from the video as a thumbnail by default, so I presume that this bug only impacts replays of lives. And I presume that it's a bug and not intended behavior for the same reason.

As always, thank you for everything that you do for all of us who host PeerTube instances; this software has done so much for me. If I can provide more information or assist with testing, please let me know.

Additional information

  • PeerTube instance:
    • URL: https://tube.vencabot.com
    • Version: 6.3.2

vencabot avatar Oct 09 '24 12:10 vencabot

I have also had this now on some lives. But at least it is not stuck in transcode. This is on 6.3.2

stevespaw avatar Oct 09 '24 12:10 stevespaw

Also seeing this. I noted that if you change the thumbnail of the replay, it will remove the preview image on the original live.

kntndrsn avatar Oct 14 '24 03:10 kntndrsn

Also seeing this. I noted that if you change the thumbnail of the replay, it will remove the preview image on the original live.

At first I thought that I couldn't reproduce this, but it seems like the behavior is different on mobile vs desktop.

In LibreWolf (Firefox) on desktop, my original lives still show their thumbnails as I originally configured them. This is still the case even when I clear my cache and refresh.

In Chrome on Android, the thumbnails for my original lives show a broken image (as though the source image is missing).

I'll try to do some additional testing to confirm that the thumbnails are visible normally until the replay is manually given a thumbnail. I'll report here again soon.

vencabot avatar Oct 14 '24 21:10 vencabot

Thanks! Should be fixed by https://github.com/Chocobozzz/PeerTube/commit/1606e41195991c729718f9bfc76dc84eff72c83f

Chocobozzz avatar Oct 22 '24 09:10 Chocobozzz

Thank you so much!

vencabot avatar Oct 22 '24 15:10 vencabot