Chocobozzz
Feature 1322-v2
Description
Second iteration of #1322 using the embedded player and creating the image from the player.
Related issues
#1322
Has this been tested?
- [ ] 👍 yes, I added tests to the test suite
- [x] 💭 no, because this PR is a draft and still needs work
- [ ] 🙅 no, because this PR does not update server code
- [ ] 🙋 no, because I need help
Screenshots
Advanced Settings section has been updated with a "Select from video" option.
When the user selects "Select from frame", the embedded player is loaded.
The user can play through the video to select an image.
When the user selects "Use frame" the preview is updated.
When the user clicks the normal "Update" button, the update is applied.
@Chocobozzz Hi. I tried using the my-embed component instead of making my own iframe but I'm having some challenges getting the embed api to work with it. I added a parameter allowing the API to be enabled, but it seems that the dynamically inserted iframe isn't accessible. I've tried what I can find online including ngAfterViewInit to setup the embed-api, but no luck. Any suggestions?
@Chocobozzz Hello. Please lmk if there is anything else I can do on this one.
@kntndrsn Do you need help to update the PR?
I actually didn't mean to close. I had to rebase my repo to get back to the current position and it must have decided to close it. I did initially try the two points you mentioned
- Use my-embed component (see comment above)
- Create as blob to attach so we can avoid changing server code.
Neither worked for me, but was going to give it another go when I found some time.
Please create another PR I can try so I can update your code to include my suggestions :)
Please create another PR I can try so I can update your code to include my suggestions :)
#6424