PeerTube icon indicating copy to clipboard operation
PeerTube copied to clipboard

VODs of Recurring Live Should Inherit Tags and Description

Open vencabot opened this issue 1 year ago • 2 comments

Describe the problem to be solved

When using the 'recurring Live' feature, VODs are saved to a separate Video so that the recurring Live can always use the same URL.

This is great, but the VODs are not discoverable on the Fediverse because they don't have any tags, even if the recurring Live they were spawned from DID have tags. They also have no Description and no Support modal, etc.

Describe the solution you would like

When a VOD is created as a separate entity from a recurring Live, it should, by default, get the tags, Description, support Modal, and basically everything (within reason) that the recurring Live had either when it started or when it finished. Twitch gives VODs the tags, title, description, etc., that the stream had when it STARTED. I think this makes the most sense.

vencabot avatar Jan 04 '24 08:01 vencabot

That's very true, and would be nice, so as to not have to add the tags by hand…

I hope this does not feel like hijacking this, but I may also add that it would be cool to be able to choose the timezone, and a template for the title as well… So if the lives is a weekly one, we can set the title to something like: Amazing Show - That one from %A %d/%m. (should strftime be appropriate for that…). For now, I'm not sure what timezone it uses, I guess it's the server's default.

gilou avatar Jan 05 '24 21:01 gilou

@gilou please create a dedicated issue so we can track your feature request :)

Chocobozzz avatar Jan 08 '24 08:01 Chocobozzz

Hi @vencabot

Can you try to reproduce with latest PeerTube version? Replays should keep the same metadata as the live

Chocobozzz avatar Aug 02 '24 14:08 Chocobozzz

Hi @vencabot

Can you try to reproduce with latest PeerTube version? Replays should keep the same metadata as the live

Thank you for informing me here. I just updated and did several tests for both Normal Lives and Permanent/recurring Lives.

All meta-data is carrying over for Normal Lives. Some metadata is still missing for the VOD produced from Permanent/recurring Lives.

Metadata missing from the VOD for Permanent/recurring Lives:

  • tags
  • thumbnail

Metadata that is successfully carrying over for Permanent/recurring Lives:

  • description
  • category
  • license
  • language
  • support modal

Thank you for the work you've done to address this issue and for everything you do for PeerTube.

vencabot avatar Aug 03 '24 09:08 vencabot

Thanks!

thumbnail

Should be fixed by https://github.com/Chocobozzz/PeerTube/pull/6521 where we now check if the thumbnail has been set manually to copy it in the new video.

tags

Fixed by https://github.com/Chocobozzz/PeerTube/commit/5e82c1932eb0487e55ae75417f9dc11fc585cfde

Chocobozzz avatar Aug 05 '24 14:08 Chocobozzz