PeerTube icon indicating copy to clipboard operation
PeerTube copied to clipboard
verified publisher icon Chocobozzz

Translate more strings in player stats

Open emansom opened this issue 3 years ago • 3 comments

Description

Translates more strings inside the player statistics.

Has this been tested?

  • [ ] 👍 yes, I added tests to the test suite
  • [ ] 💭 no, because this PR is a draft and still needs work
  • [x] 🙅 no, because this PR does not update server code
  • [ ] 🙋 no, because I need help

emansom avatar Sep 13 '22 14:09 emansom

Failed API tests can be ignored, they hit the timeout limit unrelated to this PR.

emansom avatar Sep 13 '22 15:09 emansom

Hi,

Thanks for the PR. Please prefer to use placeholders ({1} peers for example) instead of building manually the strings. Can you also revert your changes on translation files? It's automatically done when we update translations.

Chocobozzz avatar Sep 14 '22 07:09 Chocobozzz

Hi,

Thanks for the PR. Please prefer to use placeholders ({1} peers for example) instead of building manually the strings. Can you also revert your changes on translation files? It's automatically done when we update translations.

Done https://github.com/Chocobozzz/PeerTube/pull/5256/commits/c290244c497003523353da73ef663fc08654a1a7 👍🏻

emansom avatar Sep 14 '22 16:09 emansom

Thanks!

Chocobozzz avatar Sep 16 '22 08:09 Chocobozzz