Star
Star
Thank you for reviewing, and I apologize for keep making stupid mistakes (not strictly following the rules etc. ). I definitely should keep the good habit to write maintainable code....
So it's not a coincidence that all other test that involves png all used ```Color4f```. I had tried comparing the actuall written ```Color4f ``` and the expected ```Color4f``` using ```feq```...
I have to take back the previous comment after trying writing different values. Here's the result of my experiment: _Case 1_ ``` fill_color = Color4f(0.9f, 0.7f, 0.2f, 0.9f) Actual written...
I am Alice, and would be great if you can assign me this issue. I just added my test_imagewriter.cpp file to the build.
I can try tackle this one for macos and linux builds.
Hi, is this still a valid issue? I'd like to take this one.
Hi @xiaobeiyang , I haven't started working on this, so feel free to pick it up if you wish.
I didn't see version gating in other idempotent tests, so I am thinking about creating a standalone set of test cases that use a `Config` file whose version is `Version:Two`....
Now that I looked through other place where `where` is formatted, perhaps we should create a function `format_comment_after_where` to be used?
If we use the approach in this PR to format `where` clause in all scenarios, I think #4672 can also be resolved.