gojson icon indicating copy to clipboard operation
gojson copied to clipboard

Possible bug in isInteractive

Open dominikh opened this issue 8 years ago • 2 comments

The following line of code bitwise ORs os.ModeCharDevice with itself. This is either redundant, or meant to use another variable on the RHS:

return fileInfo.Mode()&(os.ModeCharDevice|os.ModeCharDevice) != 0
/src/github.com/ChimeraCoder/gojson/gojson/gojson.go:105:26: identical expressions on the left and right side of the '|' operator

dominikh avatar May 06 '16 09:05 dominikh

Thanks for catching this! @jmervine - do you happen to remember what you meant here?

ChimeraCoder avatar May 08 '16 23:05 ChimeraCoder

I don't and am traveling out of the country on vacation for the next two weeks. I'd be happy to look when I get back.

jmervine avatar May 09 '16 06:05 jmervine