anaconda icon indicating copy to clipboard operation
anaconda copied to clipboard

Add function to update profile with /account/update_profile

Open YoSmudge opened this issue 8 years ago • 4 comments

Support updating profiles

YoSmudge avatar May 02 '16 22:05 YoSmudge

Thanks for adding! Not sure why the CI failed on tip - let's try this again.

ChimeraCoder avatar May 09 '16 00:05 ChimeraCoder

Okay, mind rebasing this onto master? The tests should pass now.

ChimeraCoder avatar May 09 '16 01:05 ChimeraCoder

Hey,

Rebased on master now.

As for the tests, I believe the failing CI was down to requiring tests to pass on Golang tip. Since tip is the development version of Golang it's often unstable, the actual test failure was down to the latest commit on tip completely breaking the compiler.

While testing against tip is useful, this instability can lead to flapping tests and random failures, what I tend to do in my .travis.yml file is add

go:
  - 1.5
  - 1.6
  - tip

matrix:
  allow_failures:
    - go: tip

This will run the tests against tip, but won't fail the build if only tip fails.

Thanks

YoSmudge avatar May 09 '16 16:05 YoSmudge

@YoSmudge: Would you mind splitting that up in two PRs and rebasing / squashing everything? Thanks!

muesli avatar Sep 03 '17 01:09 muesli