graphql-workshop icon indicating copy to clipboard operation
graphql-workshop copied to clipboard

Fix Name nullability

Open michalMalujdy opened this issue 3 years ago • 1 comments

I propose to change the Name property to non-nullable as it is already marked with the [Required] attribute.

michalMalujdy avatar Mar 24 '21 17:03 michalMalujdy

I thought about it, but it technically can be null. The moment you create the instance its null and could by accident not being filled correctly. There are instance where I use default! to force this as well, but only if I can control exposure of the instance. For instance if we had a internal set with a dedicated factory around that.

michaelstaib avatar Aug 05 '21 10:08 michaelstaib