graphql-platform icon indicating copy to clipboard operation
graphql-platform copied to clipboard

Add directives to directive arguments

Open glen-84 opened this issue 1 year ago • 3 comments

Summary of the changes (Less than 80 chars)

  • Added directives to directive arguments.

glen-84 avatar May 29 '24 08:05 glen-84

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.88%. Comparing base (3fd69ab) to head (747d586). Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7130      +/-   ##
==========================================
+ Coverage   77.82%   77.88%   +0.05%     
==========================================
  Files        2827     2827              
  Lines      141949   141954       +5     
==========================================
+ Hits       110478   110559      +81     
+ Misses      31471    31395      -76     
Flag Coverage Δ
unittests 77.88% <100.00%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 29 '24 08:05 codecov[bot]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

  • Or via our issue tracker: https://jb.gg/qodana-issue
  • Or share your feedback: https://jb.gg/qodana-discussions

github-actions[bot] avatar May 29 '24 08:05 github-actions[bot]

This change seems to break:

StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/SchemaGeneratorTests.cs#L28

MultipleInterfaceSchema.graphql doesn't include the listConstraint directive. If I try to add it:

directive @listConstraint(minItems: Int!) on ARGUMENT_DEFINITION

I get:

  1. The specified directive @listConstraint is not allowed on the current location ArgumentDefinition. (HotChocolate.Types.DirectiveType)

Edit: It works if I add the directive to the end of the SDL ... but should this order matter?

glen-84 avatar Jun 03 '24 15:06 glen-84