graphql-platform icon indicating copy to clipboard operation
graphql-platform copied to clipboard

Fix fusion file uploads where IFile is in a list

Open Enterprize1 opened this issue 1 year ago • 2 comments

Because discovering files in a ListValueNode called .Value on the items the CollectFiles method was called with the wrong type leading the discovery mechanism to not look inside the Nodes contained in a list.

Closes #7093

Enterprize1 avatar May 07 '24 11:05 Enterprize1

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 07 '24 11:05 CLAassistant

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.18%. Comparing base (9515881) to head (d4b394e).

Files Patch % Lines
...Abstractions/Serialization/Utf8JsonWriterHelper.cs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7094      +/-   ##
==========================================
- Coverage   79.75%   79.18%   -0.58%     
==========================================
  Files        2645     2662      +17     
  Lines      132626   133189     +563     
==========================================
- Hits       105781   105468     -313     
- Misses      26845    27721     +876     
Flag Coverage Δ
unittests 79.18% <0.00%> (-0.58%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 11:05 codecov[bot]

Thanks for contributing ... I will have a look at it.

michaelstaib avatar May 13 '24 07:05 michaelstaib