graphql-platform icon indicating copy to clipboard operation
graphql-platform copied to clipboard

HotChocolate.Caching 13.9.0 returns empty response

Open kiangkuang opened this issue 10 months ago • 6 comments

Product

Hot Chocolate

Version

13.9.0

Link to minimal reproduction

https://github.com/kiangkuang/HotChocolateDemo/tree/13.9

Steps to reproduce

  1. Clone project
  2. Run project and query with
    query {
        book {
            title
        }
    }
    

What is expected?

Response with cache control headers and query result, like in version 13.8.1 image

What is actually happening?

Response with cache control headers but response is empty image

Relevant log output

No response

Additional context

No response

kiangkuang avatar Apr 13 '24 12:04 kiangkuang

I'm able to reproduce this. Looking into it.

tobias-tengler avatar Apr 13 '24 19:04 tobias-tengler

This seems to have been broken since #6844. The snapshots even shows us that it's broken 😞 https://github.com/ChilliCream/graphql-platform/pull/6844/files#diff-2803ba1ef05352c4221908b033e53e6563c564873702b5ced27ddd6b495f0f5d

tobias-tengler avatar Apr 13 '24 19:04 tobias-tengler

Same probleme here. I use: .AddCacheControl() .ModifyCacheControlOptions(o => o.DefaultMaxAge = 60_000) .UseQueryCachePipeline()

HotChocolate.AspNetCore - 13.9.3 HotChocolate.Caching - 13.9.3

miko866 avatar May 14 '24 08:05 miko866

@tobias-tengler is this fixed? What is the issue here?

michaelstaib avatar Jun 23 '24 09:06 michaelstaib

This right here still needs to be addressed: https://github.com/ChilliCream/graphql-platform/pull/7057#discussion_r1564926829 It probably needs some more considerations. Would be great if you could take a look :)

tobias-tengler avatar Jun 23 '24 09:06 tobias-tengler

The problem still persists in the version 13.9.7

miko866 avatar Jul 16 '24 17:07 miko866

I am using HotChocolate.AspNetCore - 13.9.12, HotChocolate.Caching - 13.9.12 still facing same issue

Program.cs .AddGraphQLServer() .AllowIntrospection(false) .AddAuthorization() .AddFiltering() .AddProjections() .AddQueryType<Query>() .AddTypeExtension<QueryExtended>() .AddSorting() .AddCacheControl() .UseQueryCachePipeline() .InitializeOnStartup();

keevee1988 avatar Sep 19 '24 20:09 keevee1988

@keevee1988 13.9.12 does not include the merged fix yet, you can try waiting for the next release

kiangkuang avatar Sep 20 '24 19:09 kiangkuang

@keevee1988 13.9.12 does not include the merged fix yet, you can try waiting for the next release

Thank you for the update

keevee1988 avatar Sep 22 '24 16:09 keevee1988