Fixed SSE connection not closing when an exception is thrown
Closes #6698
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.78%. Comparing base (
00b4fdf) to head (6f2aad0).
Additional details and impacted files
@@ Coverage Diff @@
## main #7007 +/- ##
==========================================
- Coverage 72.73% 69.78% -2.95%
==========================================
Files 2599 2567 -32
Lines 129629 128287 -1342
==========================================
- Hits 94284 89529 -4755
- Misses 35345 38758 +3413
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 69.78% <100.00%> (-2.95%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We have completely reworked the formatter here: https://github.com/ChilliCream/graphql-platform/pull/6981
We cannot merge this one as we already have a PR with a new version of this.
Are you merging #6981 into v13? If not, I can change the base
@sunghwan2789 can you check if HC 14 solves your problems?
@sunghwan2789 can you check if HC 14 solves your problems?
yes, it works in HC 14. thanks!