graphql-platform icon indicating copy to clipboard operation
graphql-platform copied to clipboard

[HotChocolate] Removed libraries available as part of framework from the reference list.

Open thompson-tomo opened this issue 2 years ago • 1 comments

Summary of the changes

Have gone and done a cleanup of dependencies so that if the framework can provide them it does rather than an explicit dependency

Details of change

  • Removed the below dependencies from projects targeting NET6.0+ and have the ASPNET framework reference
    • Microsoft.Extensions.Configuration.Abstractions
    • Microsoft.Extensions.Http
  • Removed the below dependencies from projects targeting NET6.0+ and have the ASPNET framework reference
    • System.Collections.Immutable
    • System.ComponentModel.Annotations
    • System.Diagnostics.DiagnosticSource
    • System.Text.Json
    • System.Threading.Channels
  • Removed item group conditions which reference netstandard2.1 when it wasn't a TFM

Closes #6869

thompson-tomo avatar Feb 11 '24 05:02 thompson-tomo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.51%. Comparing base (686f705) to head (8a3542a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6881      +/-   ##
==========================================
- Coverage   73.15%   70.51%   -2.64%     
==========================================
  Files        2596     2596              
  Lines      128977   128977              
==========================================
- Hits        94357    90953    -3404     
- Misses      34620    38024    +3404     
Flag Coverage Δ
unittests 70.51% <ø> (-2.64%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 11 '24 05:02 codecov[bot]

Just tested it ... thanks for your contribution.

michaelstaib avatar Feb 23 '24 10:02 michaelstaib

No worries.

thompson-tomo avatar Feb 23 '24 13:02 thompson-tomo