graphql-platform icon indicating copy to clipboard operation
graphql-platform copied to clipboard
verified publisher icon ChilliCream

#6197: Remove IsValueType check from AnyType.TrySerialize method

Open EvilVir opened this issue 2 years ago • 6 comments

Closes #6197

(PR redo to proper branch).

EvilVir avatar May 25 '23 08:05 EvilVir

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 25 '23 08:05 CLAassistant

Can you sign the CLA?

michaelstaib avatar May 26 '23 05:05 michaelstaib

Done :)

EvilVir avatar May 26 '23 12:05 EvilVir

Can you add a unit test for this? Every change needs a test.

michaelstaib avatar Jun 01 '23 15:06 michaelstaib

Also, can you target main?

michaelstaib avatar Jun 01 '23 16:06 michaelstaib

@michaelstaib hi, two unit tests added and target branch changed. Sorry for the delay - I was on the vacations :)

EvilVir avatar Jun 27 '23 22:06 EvilVir